Sonar Fix (Java backend)

This is a record for sonar fixing for backend based on Java.

CERT issues

Extract this increment or decrement operator into a dedicated statement.

Rule: Increment (++) and decrement (–) operators should not be used in a method call or mixed with other operators in an expression

1. original code:

u8a = ++u8b + u8c--;
foo = bar++ / 4;

solution

++u8b;
u8a = u8b + u8c;
u8c--;
foo = bar / 4;
bar++;

2. original code:

if (++searchCounter > portRange) {
  //...
}

solution

++searchCounter;
if (searchCounter > portRange) {
}

3. original code:

int retry = 0;
while (retry++ < RETRY_NUM && ..) {
  // ...
}

solution

int retry = 1;
while (retry < RETRY_NUM + 1 && ..) {
  // ...
  retry++;
}

4. original code:

int cnt = 0;
while ((++cnt <= num) && (...)) {
	// ...
}

solution

int cnt = 1;
while ((cnt <= num) && (...)) {
	// ...
  cnt++;
}

---

Specify an appropriate locale when comparing locale-dependent data.

2. original code:

String password = user.getPassword().toLowerCase();

solution

String password = user.getPassword().toLowerCase(Locale.getDefault());

---

Classes and methods that rely on the default system encoding should not be used

Rule: 1. Remove this use of “toString”. 2. Remove this use of constructor “FileWriter(File,boolean)”. etc

1. original code:

import java.io.FileWriter;

BufferedWriter csvFileBufferWriter = new BufferedWriter(new FileWriter(csvFile, true))

solution

import java.io.FileOutputStream;
import java.io.OutputStreamWriter;
import java.nio.charset.Charset;

BufferedWriter csvFileBufferWriter = new BufferedWriter(new OutputStreamWriter(new FileOutputStream(csvFile, true), Charset.defaultCharset()))

This solution came out with new sonar issue https://sonarqube.lmera.ericsson.se/coding_rules?open=fb-contrib%3AIOI_USE_OF_FILE_STREAM_CONSTRUCTORS&rule_key=fb-contrib%3AIOI_USE_OF_FILE_STREAM_CONSTRUCTORS
2nd modification:

import java.nio.file.Files;

BufferedWriter csvFileBufferWriter = new BufferedWriter(new OutputStreamWriter(Files.newOutputStream(csvFile.toPath()), Charset.defaultCharset()))

another case:

File file = new File(saiFileLocation);
FileInputStream reader = new FileInputStream(file);

change to

InputStream reader = Files.newInputStream(Paths.get(saiFileLocation));

2. original code:

try {
  // ...
} catch (JAXBException e) {
  throw new RuntimeException();
}
return bos.toString();

solution

try {
  // ...
  return bos.toString(Charset.defaultCharset().name());
} catch (JAXBException | UnsupportedEncodingException e) {
  throw new RuntimeException();
}

3. original code:

import java.io.FileReader;

try (FileReader fileReader = new FileReader(fileName)) {
  List<..> list = unmarshal2List(fileReader);
}

solution

import java.io.FileInputStream;
import java.io.InputStreamReader;
import java.nio.charset.Charset;

try (FileInputStream fileReader = new FileInputStream(fileName)) {
  List<..> list = unmarshal2List(new InputStreamReader(fileReader, Charset.defaultCharset()));
}